feat: Rework config hierarchy - Githubissues

Snowflake-Labs / terraform-provider-snowflake

Terraform provider for managing Snowflake accounts

https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest

MIT License

552 stars 420 forks source link

feat: Rework config hierarchy #3166

Closed sfc-gh-jmichalak closed 2 weeks ago

sfc-gh-jmichalak commented 3 weeks ago

add remaining fields to the schema
deprecate account
implement and use a helper function for matching provider versions in acceptance tests
use helpers to fill config values
add acceptance tests for all fields in the config
move some code to internal package
improve documentation: describe config hierarchy and provide better config file examples
improve and test sdk.MergeConfig
move mock helper to a separate package because it caused unnecessarily registered sqlmock driver in one of the tests

Test Plan

[x] acceptance tests
[x] unit tests

References

https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/1881 https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2145 https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2925 https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2983 https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/3104

TODO

acceptance test for fields regarding private keys - will be done in SNOW-1754319
unskip some tests after creating a compatible config for older versions

github-actions[bot] commented 3 weeks ago

Integration tests failure for 53cc9dc025b2e34c3914fe454d06c5ee5479b08c

github-actions[bot] commented 3 weeks ago

Integration tests cancelled for b3bb72dd89b7d9f21c693b392993bdbf249c82f2

github-actions[bot] commented 3 weeks ago

Integration tests cancelled for 94dfe58adcf7fd6909a90f66a1929c4f9f9765f5

github-actions[bot] commented 3 weeks ago

Integration tests failure for 83146de4c284f6eb624fdabd85fb1d4bda16b7c7

github-actions[bot] commented 3 weeks ago

Integration tests failure for bfd73028b05ca4d97d4f7bbea9d48d3b42b5cca2

github-actions[bot] commented 3 weeks ago

Integration tests failure for 5f0fa00258a238476972f22053fa727318ef32ef

github-actions[bot] commented 2 weeks ago

Integration tests failure for af1a6f8d5ea244752ff2ec1631490341f84b7845

github-actions[bot] commented 2 weeks ago

Integration tests failure for 91c05617abf5ddfcd937d0d28e6ee63c1b5bfc0d

github-actions[bot] commented 2 weeks ago

Integration tests failure for 91c05617abf5ddfcd937d0d28e6ee63c1b5bfc0d

github-actions[bot] commented 2 weeks ago

Integration tests failure for a888620c9a9bbc34730d7b96536a2399fa9aa74e

github-actions[bot] commented 2 weeks ago

Integration tests cancelled for 65e7b4c456e43ca7e30b4aa90e5adcf52a4cc49c