feat: Task resource v1 readiness part 2

sfc-gh-jcieslak commented 2 weeks ago

[x] Apply comments from https://github.com/Snowflake-Labs/terraform-provider-snowflake/pull/3086
[x] Check if more helper functions from user resource could be used in task resource.
[ ] Apply comments from https://github.com/Snowflake-Labs/terraform-provider-snowflake/pull/3113
- [x] Cron https://github.com/Snowflake-Labs/terraform-provider-snowflake/pull/3113#discussion_r1789842978
- [ ] Resource logic https://github.com/Snowflake-Labs/terraform-provider-snowflake/pull/3113#discussion_r1789869045
- [ ] Refactor SDK suspend root logic for tasks (and overall suspend logic in SDK/resource) https://github.com/Snowflake-Labs/terraform-provider-snowflake/pull/3113#discussion_r1789872814
[ ] Move some of the logic to SDK (if possible)
- [ ] https://github.com/Snowflake-Labs/terraform-provider-snowflake/pull/3170#discussion_r1838382878
[ ] Refactor task resuming in task resource (most likely with the use of defer) because currently, there may be cases that error can cause tasks to be not resumed.
[ ] Tests
- [ ] External changes - https://github.com/Snowflake-Labs/terraform-provider-snowflake/pull/3113#discussion_r1789903936
- [ ] Add more complicated DAG structures to show the resource can handle more complex structures
- [ ] Calling (as field) - https://github.com/Snowflake-Labs/terraform-provider-snowflake/pull/3113#discussion_r1789900590
- [ ] For showing how the DAG of tasks could be owned by a role other than the one created with Terraform (also with less privileges, only to run the task).
- [ ] Check in one acceptance test why finalizer task in show_output is not set (is that Snowflake or mapping error).
[ ] Data source
[ ] Examples, documentation, and migration guide
[ ] Keep manually changed files after regeneration https://github.com/Snowflake-Labs/terraform-provider-snowflake/pull/3113#discussion_r1802561725
[ ] Make config without $$ escapes needed
[ ] Support session paramters
[ ] Analyze non-deterministic test cases
[ ] Check test tasks_gen_integration_test.go:937 (and see why it's non deterministic).
[ ] Re-generate and list all the issues with asserts and models