fix: Apply various fixes

sfc-gh-asawicki commented 2 weeks ago

Apply various fixes:

Fix handling compute pool privileges (#2717)
Fail to reproduce the problem with password policy user attachment (#3005)
Adapt user to BCR Bundle 2024_08 (#3125)
Loosen identifier validations - parentheses (#3127) - check below
Prove MANAGE SHARE TARGET works correctly (#3153)

On the identifier validation topic: ParseIdentifierString should generally allow parentheses. It should validate them for the identifiers for functions, procedures, etc. Because of that:

this validation was removed
method usages were analyzed to check what consequences it has throughout the provider
- DecodeSnowflakeAccountIdentifier - OK, account level identifier
- DecodeSnowflakeParameterID
- buildOptsForGrantsOn (grants datasource) - NOK, had to fix the logic
- ContainsIdentifierIgnoringQuotes - OK, transitively used only in network policies
- TestDecodeSnowflakeParameterID - OK
- IsValidIdentifier - OK, used for other identifier types
- pkg/resource - OK, used in streams, table constraints and tag masking policy associations
- suppressIdentifierQuoting
- used in non-grant resources with non-argument identifier types - OK
- used in grant resources - OK, the validation will be relaxed for now, diff suppression won't work correctly for the identifiers with arguments, will be addressed with functions/procedures rework (multi-field validation could be handled for such cases, issue added; references: https://github.com/hashicorp/terraform-plugin-sdk/issues/354, https://github.com/hashicorp/terraform-plugin-sdk/issues/233)
- suppressIdentifierQuotingPartiallyQualifiedName - as above; currently used only for streams
- parseIdentifier - used by other identifier types (type constraints added)
- ParseObjectIdentifierString - OK, used for other identifier types (ParseSchemaObjectIdentifierWithArguments is dedicated for identifier with arguments)
- ParseSchemaObjectIdentifierWithArguments - OK, we split the input string on first opening paren (so there are no other opening parens there)
- Test_ParseIdentifierString - tests adjusted for the removed validation

Others:

Remove unused privileges.go file
Fix preview resources list for V1

References:

github-actions[bot] commented 2 weeks ago

Integration tests cancelled for 807aadc86174c3aa544470b787f259c3c5becc99

github-actions[bot] commented 2 weeks ago

Integration tests failure for 3096dca0239a93b690dbfb9825bf066f8cb8676c

github-actions[bot] commented 2 weeks ago

Integration tests failure for 1ff9b6dbcb5af401ce7049b206c20f379278c22b

Snowflake-Labs / terraform-provider-snowflake

fix: Apply various fixes #3176