Snowflake-Labs / terraform-provider-snowflake

Terraform provider for managing Snowflake accounts

https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest

MIT License

552 stars 420 forks source link

feat: Tag association v1 readiness #3210

Open sfc-gh-jmichalak opened 1 day ago

sfc-gh-jmichalak commented 1 day ago

rework tag_association resource
return nil from GetTag instead of failing
add more tests regarding tag/masking policy: assert that ALTER MASKING POLICY SET TAG differs from ALTER TAG SET MASKING POLICY
support tagging account for identifiers with org name
support IF EXISTS for unsetting tags
add notes about manually unassigning policies from objects, add a todo with an issue number
fix a wrong issue number in essential objects list

Test Plan

[x] acceptance tests
[ ] …

References

https://docs.snowflake.com/en/user-guide/object-tagging https://docs.snowflake.com/en/sql-reference/functions/system_get_tag

3145

1910

2943

TODO

use generated config and asserts, remove old test tf files

Ideas

extract a separate resource for tagging accounts?

github-actions[bot] commented 1 day ago

Integration tests failure for 8aa6ea667b3781751030a662948cb08d39c1c647

github-actions[bot] commented 1 day ago

Integration tests failure for f97b0e8b9fdee53a6442fa8b6e76eaf351a5ba06

github-actions[bot] commented 15 hours ago

Integration tests success for 818d00b33e87a83140565a1320a695221e9e66c1