search

SnowflakePowered / librashader

RetroArch Shaders for All
Mozilla Public License 2.0
77 stars 7 forks source link

Some shaders output corrupted textures in DirectX 11 #7

Closed chyyran closed 1 year ago

chyyran commented 1 year ago 
    This is scalefx\scalefx-9x.slangp in Retroarch:

image

Here it is in Librashader: image

Originally posted by @star69rem in https://github.com/SnowflakePowered/librashader/discussions/2#discussioncomment-4821309

chyyran commented 1 year ago

RenderDoc caps:

https://archive.org/details/scalefx-aa-capture1 https://archive.org/details/zfast-crt-capture1

chyyran commented 1 year ago

ScaleFX issue is due to preset overriding framebuffer format to float.

zfast is potentially due to DX11 not setting blend state, which is fixed in https://github.com/SnowflakePowered/librashader/commit/5ffcf005a0920c9e2166078ddc9d677cc48f4492.

Waiting on @star69rem to report back before confirming.

star69rem commented 1 year ago

zfast works now. scalefx immediately crashes. checking...

star69rem commented 1 year ago

Nvwgf2umx.pdb not loaded error when running scalefx.

star69rem commented 1 year ago

crt royale crashes now too. lottes still works.

star69rem commented 1 year ago

Do I need to replace the includes? Were there changes that would break things there?

star69rem commented 1 year ago

Exception thrown at 0x00007FFFF9FD352C (nvwgf2umx.dll) in .exe: 0xC0000005: Access violation reading location 0x0000000000000000.

star69rem commented 1 year ago

The crashing is inconsistent. It actually ran once. Seems like it crashes on filter_chain_create. Interestingly, crt royale is WAY faster than it was before. I get full speed now.

chyyran commented 1 year ago

Closing this as fixed by the blend state issue patches. We can continue discussion on crashing issues in the discussion thread. https://github.com/SnowflakePowered/librashader/discussions/2