Snowiiii / Pumpkin

Empowering everyone to host fast and efficient Minecraft servers.
https://snowiiii.github.io/Pumpkin/
MIT License
3.26k stars 113 forks source link

Implemented Sign Editing Functionalities #262

Open whiteout314 opened 1 week ago

whiteout314 commented 1 week ago

Description

Currently signs cannot be edited. Added the following:

Testing

whiteout314 commented 1 week ago

demo

leobeg commented 6 days ago

There is also an error when the block gets updatet trough the CAcknowledgeBlockChange packet. Then the popup instantly goes away

leobeg commented 5 days ago

@whiteout314 why was this PR closed?

DataM0del commented 5 days ago

oof

whiteout314 commented 5 days ago

Sorry about that looks like I had an issue last night updating and pushing to my branch

leobeg commented 2 hours ago

Will this be merged soon? It would be a base for following block entities.

OfficialKris commented 1 hour ago

Block entities are also required for many things. I wanted to add jukebox support and even that requires it (storing disc). Will this be merged soon? I tested and it works for me.