Snowiiii / Pumpkin

Empowering everyone to host fast and efficient Minecraft servers.
https://snowiiii.github.io/Pumpkin/
MIT License
3.25k stars 113 forks source link

Disconnecting from server doesn't remove you from the server #302

Open StefanB7 opened 5 days ago

StefanB7 commented 5 days ago

I've searched existing issues and couldn't find a duplicate.

Operating System

Ubuntu 24.04

Server Software Version/Commit

0.1.0/00af2b98683b11946cddb4f08de3b0ce04c1fddd

What happened?

The server doesn't remove players when they disconnect (using the disconnect button in the client menu). This leads to the player not able to join the server again, as the server thinks they are already connected to the server.

2024-11-17 11:23:53 INFO  [pumpkin::world@tokio-runtime-worker] stefan joined the game.
2024-11-17 11:23:54 WARN  [pumpkin::entity::player@tokio-runtime-worker] Failed to handle player packet id 8
2024-11-17 11:24:01 INFO  [pumpkin@main] Accepted connection from: xxx.x.x.x:xxxxx (id 1)
2024-11-17 11:24:14 INFO  [pumpkin@main] Accepted connection from: xxx.x.x.x:xxxxx (id 2)
2024-11-17 11:24:14 INFO  [pumpkin::client@tokio-runtime-worker] Kicking Client id 2 for You are already connected to this server
2024-11-17 11:24:23 INFO  [pumpkin::entity::player@tokio-runtime-worker] Kicked Player stefan (0) for Timeout

After the kick occurs due to the timeout, that player is still not able to join.

To Reproduce

Expected behavior

The server should recognize the player has disconnected and remove them from the server, allowing them to join at a later time.

Snowiiii commented 4 days ago

I can't reproduce this. Since you also opened https://github.com/Snowiiii/Pumpkin/issues/301. It is maybe an issue with the Auth Server