Snowiiii / Pumpkin

Empowering everyone to host fast and efficient Minecraft servers.
https://snowiiii.github.io/Pumpkin/
MIT License
3.25k stars 113 forks source link

Cleanup pumpkin-config #303

Closed Commandcracker closed 2 days ago

Commandcracker commented 5 days ago

Description

Most changes are because serde_inline_default is no longer needed, see here

Testing

ran diff on booth configs to see if anything changed.

Checklist

Things need to be done before this Pull Request can be merged.

Snowiiii commented 4 days ago

The only reason we use serde_inline_default is to have default values for config fields we can't parse. I tested your changes and removed a random config value. It gave me an error Couldn't parse config at "configuration.toml". Reason: missing fieldhardcore. This is is proberbly caused by an Config update, Just delete the old Config and start Pumpkin again

Commandcracker commented 3 days ago

The only reason we use serde_inline_default is to have default values for config fields we can't parse. I tested your changes and removed a random config value. It gave me an error Couldn't parse config at "configuration.toml". Reason: missing fieldhardcore. This is is proberbly caused by an Config update, Just delete the old Config and start Pumpkin again

Now it should work

Snowiiii commented 2 days ago

Just tested again. Works fine now and looks much better. Thanks @Commandcracker :D