Snowiiii / Pumpkin

Empowering everyone to host fast and efficient Minecraft servers.
https://snowiiii.github.io/Pumpkin/
MIT License
3.25k stars 113 forks source link

Use sysinfo, this will fix #311 #314

Closed Commandcracker closed 3 days ago

Commandcracker commented 3 days ago

Description

sysinfo is actively developed, supports android and will default no null values if the OS is not detected. (See https://github.com/Snowiiii/Pumpkin/issues/311#issuecomment-2483096761)

Testing

Ran on Win11 and linux (wls docker) and android (Samsung tabled)

Windows Screenshot 2024-11-18 203025 Android image Docker Screenshot 2024-11-18 204723

Checklist

Things need to be done before this Pull Request can be merged.

Snowiiii commented 3 days ago

LGTM. Thanks @Commandcracker