Add Cookies - Githubissues

Snowiiii / Pumpkin

Empowering everyone to host fast and efficient Minecraft servers.

https://snowiiii.github.io/Pumpkin/

MIT License

3.25k stars 113 forks source link

Add Cookies #325

Open Commandcracker opened 20 hours ago

Commandcracker commented 20 hours ago

Description

very WIP just made this draft, so everyone can see that in working on it

Testing

Checklist

Things need to be done before this Pull Request can be merged.

[ ] Code is well-formatted and adheres to project style guidelines: cargo fmt
[ ] Code does not produce any clippy warnings cargo clippy

DataM0del commented 15 hours ago

Nothing succeeded :skull:

DataM0del commented 15 hours ago

Oh... perfect!

Commandcracker commented 5 hours ago

CO>>KK<<IES PROTOCOL 💀 (typo moment) ...

Didn't want to waste my time trying to change a commit message before pushing.

...also, not sure if you can trick the server and send a payload longer than 5 kilobytes (kB) and setting a fake length. Would that just crash the server or something? Will look after this review to see.

Should try it, I just added to protocol for now.

Commandcracker commented 5 hours ago

Nothing succeeded 💀 Oh... perfect!

I can also see the GH actions ._. Did you even read this ? very WIP just made this draft, so everyone can see that in working on it