search

Snowiiii / Pumpkin

Empowering everyone to host fast and efficient Minecraft servers.
https://snowiiii.github.io/Pumpkin/
MIT License
2.64k stars 78 forks source link

Add permissions check for SSetCreativeSlot #51

Closed Bryntet closed 2 months ago

Bryntet commented 2 months ago

make sure the players gamemode is creative when client sends SSetCreativeSlot

Snowiiii commented 2 months ago

You have a good commit message, Why you don't use that for the PR description. There are many people using "self explanatory commit" or something like this in PR and i really hate it. So would be cool if you could use good commit messages and good PR descriptions in the future 👍

Bryntet commented 2 months ago

updated my PR message :)

Bryntet commented 2 months ago

that should be fixed now

Snowiiii commented 2 months ago

Looks good, Thanks