search

Snowiiii / Pumpkin

Empowering everyone to host fast and efficient Minecraft servers.
https://snowiiii.github.io/Pumpkin/
MIT License
2.64k stars 78 forks source link

Removed unused #[allow()]'s #69

Closed DaniD3v closed 1 month ago

DaniD3v commented 2 months ago

title

DaniD3v commented 2 months ago

This only fails CI on stable. Works on my nightly. I think they patched the broken lint.

Let's wait for 1.81 release which is in 4 days.

Snowiiii commented 2 months ago

1.81 is out. still failing

DaniD3v commented 1 month ago

I'm using the nightly toolchain so it might've been fixed in 1.82. I'm just gonna remove the one case

I'll also replace the existing allows with expect.

DaniD3v commented 1 month ago

expect was newly added in 1.81 and warns if an #[allow] hint is not necessary anymore.

Snowiiii commented 1 month ago

Looks good. Thank you @DaniD3v