Snownee / Cuisine

Customize your food
https://www.curseforge.com/minecraft/mc-mods/cuisine
MIT License
51 stars 13 forks source link

Chopping Board Part 2 #39

Closed Fortist closed 5 years ago

Fortist commented 5 years ago

So, I have NoTreePunching a mod that uses saws (which extends itemAxe, I assume) to craft planks from logs in the crafting table.

choppin2

However, with Cuisine added, it would create a chopping board with the saw above log recipe. I had a problem where I tried to disable the chopping board recipe with crafttweaker only for it to not work as intended, even using all the nbt data/tag data/whatever.

recipes.remove(<cuisine:chopping_board>);
recipes.remove(<cuisine:chopping_board>.withTag({BlockEntityTag: {cover: {id: "minecraft:log", Count: 1 as byte, Damage: 0 as short}}}));

So I took a drastic measure and just deleted the recipe json in the jar itself to 'fix' the recipe conflict, It works in the way that I can now make planks with saw in the crafting table, but due to some underlying code the axe+log recipe still shows up, despite it not actually working. choppin

On another side, there doesnt need to be a chopping board per log, and I have a mod that adds a log that is "white" in texture but changes colors due to NBT or whatever and they all show up as white chopping boards. A little more control over what becomes a chopping board would be nice.

3TUSK commented 5 years ago
  1. In fact, the only reliable way to remove a recipe is to remove it by its recipe ID. Either remove by input or output is practically unreliable. Also it is strongly discouraged to tamper the jar - it makes impossible for us to make sure that the jar is indeed from us.
    See CraftTweaker Documentation for details about recipes.removeByRecipeName.
    // This is guaranteed working.
    recipes.removeByRecipeName("cuisine:chopping_board");
  2. That issue of JEI displaying ghost recipe will be investigated.
  3. Which mod is that colored log come from anyway? I would assume it is something wrong on Cuisine's side, but I need to know the details.
  4. As for "a little more control over what becomes a chopping board" - this will be considered.
Snownee commented 5 years ago

Have you tried to use saw to chop log?

Fortist commented 5 years ago

The mod in question is "Natural Pledge." The Iridescent Logs, to be exact. Also, I have no idea what that means, Snow. But to show you what I mean, this is just the two mods together, no crafttweaking.

2019-02-12_21 39 31

I know what Im doing when I mess with .jar files. Especially anything under assets. But to your credit, using the recipe name in crafttweaker worked, however the ghost recipes still show up.

3TUSK commented 5 years ago

Iridescent Logs

Will investigate

however the ghost recipes still show up

Already addressed by https://github.com/Snownee/Cuisine/commit/10de85ab1f627a5f32732af986e33cf6660c85d0 one week ago

Snownee commented 5 years ago

Make a chopping board, then make planks by using chopping board and log in world

Fortist commented 5 years ago

That has nothing to do with what Im talking about Snow.

Snownee commented 5 years ago

I think what your problems are:

  1. Chopping board recipe can not be removed (actually can) 1.1. Chopping board recipe still being shown in JEI after removing (fixed in dev)
  2. Cannot make planks if there is a recipe conflict. (yes it is conflict but you can still make planks)
3TUSK commented 5 years ago

2019-02-13_16 21 58 @Fortist Fixed in dev

Also, the wood log in the inventory is the Rainbow Wood (which already works with Chopping Board).