search

SnowyMouse / chimera

The update to Halo PC that never was
https://chimera.opencarnage.net
GNU General Public License v3.0
137 stars 26 forks source link

Widescreen tweaks and Interpolation bug fix #29

Closed MangoFizz closed 3 years ago

MangoFizz commented 3 years ago

Hey Kava, maybe this could be useful.

Changes:

SnowyMouse commented 3 years ago

Hello, Jerry. Thanks for your contributions!

You might notice that, when you tweak the widescreen fix, you can fix some maps. However, this can come at the cost of breaking others. For example, the numbers next to "TARGET DISTANCE:" and "TARGET ELEVATION:" in stock maps is broken with your changes.

Unfortunately this is the nature of widescreen fixes, and you'll find that no widescreen fix can truly fit every situation with the large variety of custom HUDs out there. Perhaps this issue should be addressed by implementing some sort of method to define it as a map-by-map basis rather than globally. I'm considering an ini option in that case.

For your other contribution: the pause thing is good and has been needed for a while (I've never really gotten around to it, so thanks!). My only comment on it is that you used a hardcoded address, and the particular address you used is invalid for the demo version of the game. This isn't a problem, as I've found the signature for it, so it can be pretty easily adapted to work on all supported versions.

Again, thanks! I rarely ever get PRs on my projects, so I'm very pleased to respond to yours.

MangoFizz commented 3 years ago

Hmm I see, so the best option will be fix that HUD to match with the the current widescreen fix settings.

About the pause menu thing, I'm glad to know that will be useful. I tried to make a signature for the memory address but I couldn't, my knowledge about those stuff is very limited.

I also have a couple of patches for the game that maybe could be in Chimera. Should I open a new pull request (I will be more careful with some details next time haha) or just tell you on the Chimera discord server?

Glad to contribute (in some way) to this project 👍

SnowyMouse commented 3 years ago

Yes, of course! If you want to talk with me on the Chimera Discord about this, go ahead.

Anyway, if you can, try putting individual features and enhancements into separate pull requests. I know that might be a bit more work, but it'd be a easier to handle since they can be approved separately rather than all together.

Aerocatia commented 3 years ago

Hi, do you mind making the pause fix its own pull request so it can be merged?

MangoFizz commented 3 years ago

Oh yes I forgot, sorry!