SnowyMouse / chimera

The update to Halo PC that never was
https://chimera.opencarnage.net
GNU General Public License v3.0
147 stars 27 forks source link

Fix extended description #31

Closed MangoFizz closed 4 years ago

MangoFizz commented 4 years ago

This fixes the extended description of the "About" button in the profile settings menu.

SnowyMouse commented 4 years ago

Checked against the demo version and retail version of the game and it works. However, the "OK" and "CANCEL" button appear to be borked.

https://i.imgur.com/qjeFGWi.png

From looking at your code on line 12, you changed a

cmp ecx, 8

to a

cmp ecx, 9

If you don't do this, then the issue doesn't appear to occur, and the bitmap is still fixed. Let me know if that works or if you're getting something different.

Thanks, as always!

edit: included line number

MangoFizz commented 4 years ago

Fixed!

Sorry, I was testing it on a modified version of the stock UI. Now I made a clean copy of my Halo CE so this doesn't happen again.

SnowyMouse commented 4 years ago

Excellent. It works!