"chimera_load_ui_map" crashes the game.

SnowyMouse / chimera

The update to Halo PC that never was

https://chimera.opencarnage.net

GNU General Public License v3.0

137 stars 26 forks source link

"chimera_load_ui_map" crashes the game. #54

Closed Aerocatia closed 3 years ago

Aerocatia commented 3 years ago

Some recent change has broken this feature.

SnowyMouse commented 3 years ago

Curiously, this seems to have been broken ever since the camera shake fix was implemented. Disabling the fix causes it to not crash the game anymore.

SnowyMouse commented 3 years ago

Fixed. It seems there was a missing ret instruction, so it just kept going and executing who-knows-what.

For whatever reason, this wasn't a problem until the camera shake fix was implemented, maybe because the function placed in the DLL after it executed and returned without managing to crash the game.

Anyway, fixed in https://github.com/SnowyMouse/chimera/commit/69938f4617e6c4fbfcf5915785ff29b379758d3e