search

SnowyMouse / invader

Free toolkit for Halo: Combat Evolved for creating maps and assets
https://invader.opencarnage.net
Other
59 stars 10 forks source link

Generated parser filenames fix #213

Closed hellux closed 3 years ago

hellux commented 3 years ago

Hey, two of the parser filenames (parser-read-hek-data, parser-read-cache-file-data) are swapped because of an order mix-up in src/invader.cmake and src/tag/code_generator/__main.py__. Currently, parse_cache_file_data methods are written to parser-read-hek-data.cpp and parse_hek_tag_data methods are written to parser-read-cache-file-data.cpp.

The first commit fixes this, the second commit removes one of the manual mappings so there is one less place to accidentally write them in the wrong order.

SnowyMouse commented 3 years ago

Aaah thanks!

I'm going to be re-writing this entire system from scratch anyway, but thank you for doing this.