search

SnpM / LockstepFramework

Framework for lockstep RTS, TD, and MOBA games.
MIT License
1.4k stars 348 forks source link

ScanNode.BucketsWithAllegiance() causes a dramatically gc? #99

Closed maxin0628 closed 8 years ago

maxin0628 commented 8 years ago

Hello John,

I uses this framework in mobile game, as issue title describe, when I checked performance via profiler, I found this function had been called in a huge number and making a gc allocate frequently.

This may be not an "issue" for desktop, but this count of gc impacts frame rate dramatically on mobile devices, I've researched it for a while, but can't find a solution, could you please take a look at this function, and give some advice?

thanks Johnson

SnpM commented 8 years ago

Ah, thanks for notifying me. Going to fix this soon.

On Wed, Aug 24, 2016 at 9:21 AM, maxin0628 notifications@github.com wrote:

Hello John,

I uses this framework in mobile game, as issue title describe, when I checked performance via profiler, I found this function had been called in a huge number and making a gc allocate frequently.

This may be not an "issue" for desktop, but this count of gc impacts frame rate dramatically on mobile devices, I've researched it for a while, but can't find a solution, could you please take a look at this function, and give some advice?

thanks Johnson

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SnpM/LockstepFramework/issues/99, or mute the thread https://github.com/notifications/unsubscribe-auth/AHXqp93jhjbtNdZnk2-CNMCEFwNCDNQiks5qjGGDgaJpZM4JsIKT .

maxin0628 commented 8 years ago

Big thanks!!! Silky smooth on mobile phone now!