#46 - Implement KafkaSerializer for JSON serialization instead using …

SnuK87 / keycloak-kafka

Keycloak module to produce events to kafka

Apache License 2.0

100 stars 37 forks source link

#46 - Implement KafkaSerializer for JSON serialization instead using … #49

Closed ttimot24 closed 2 months ago

ttimot24 commented 2 months ago

Event and AdminEvent does not have a common parent class. Because of this Object is needed.

ttimot24 commented 2 months ago

@SnuK87 So I managed to solve the issues but it required huge modifications on the code. Please feel free to decide if you want to merge it or not. All of your unit tests passes.

I think with this AVRO improvement this SPI could be used in large scale projects with confidence.

Thank you!

SnuK87 commented 2 months ago

This change would destroy the whole purpose of this library. It should be as generic as possible, can be easily used with standard kafka and keycloak setups and is easy to customize for your specific use case (which is your case I guess).

Here are some things that would make this library useless for other people:

What if you want protobuf instead of avro?
Producing custom events instead of the original from keycloak makes integration more difficult
Will this even work with plain JSON?
Size of fat jar is more than 4x size

ttimot24 commented 2 months ago

It's ok if you don't merge this one. I understand.

Currently can not be used any of them in this repo nor JSON Schema
Event and AdminEvent the two thing that Keycloak produces
Yes
Yepp