search

Snugug / Aurora

Drupal HTML5 Base Theme
33 stars 14 forks source link

Corona: make browser support variables available for extensions #27

Closed pascalduez closed 10 years ago

pascalduez commented 11 years ago

In Corona the browser support variables, legacy-support-for-ie* are declared in the _variables.scss partial file and imported after all extensions. So they are not available for them.

For instance the box-sizing mixin in toolkit is never printing the polyfill.

With the following support set:

$legacy-support-for-ie6: true;
$legacy-support-for-ie7: true;

You always get:

*, *:after, *:before {
  -webkit-box-sizing: border-box;
  -moz-box-sizing: border-box;
  box-sizing: border-box;
}

Instead of:

*, *:after, *:before {
  -webkit-box-sizing: border-box;
  -moz-box-sizing: border-box;
  box-sizing: border-box;
  *behavior: url('../behaviors/box-sizing/boxsizing.php');
}
iamcarrico commented 10 years ago

So, this will be fixed by #42, by having toolkit not display any of the CSS until AFTER all variables are loaded. However, we still preserve the order of extensions being loaded in first.