search

Snugug / Aurora

Drupal HTML5 Base Theme
33 stars 14 forks source link

Parmesan to Corona #9

Closed iamcarrico closed 11 years ago

iamcarrico commented 11 years ago

So, I was chatting with @rupl, and he had an excellent point. Our "name" for the project was based on kitchen-y things, while yours is based on star-y things. So, we changed that. I also went in and removed things that we have deemed unnecessary, cleaned up the code a wee bit, etc.

DO NOT MERGE THIS YET.

Why? Because I want @rupl to confirm the changes are right with what we talked about. Also, if you take a look at https://github.com/ChinggizKhan/Corona you can see what the theme looks like when it pops out.

Snugug commented 11 years ago

So I'm happy to merge this in, I actually really like this as an alternative, but I don't like the device media queries in there. They make me :cry:

Snugug commented 11 years ago

I had a merge conflict because I had updated the gemspec stuff too, so I went ahead and just merged this. I'm not going to push a new gem until the pieces you want checked are finalized.

rupl commented 11 years ago

I agree with @Snugug about device breakpoints. Let's take them out and perhaps provide some commented examples to guide the user.

I just found this cool rwd testing tool by @bradfrost that uses S, M, L, XL as a way of avoiding the thought-pattern of device breakpoints. Goes hand-in-hand with Respond-to.

// $sample-breakpoints: "small-ish" (300px),
//                      "medium-ish" (460px),
//                      "large-ish" (770px),
//                      "extra-large-ish" (1000px);
rupl commented 11 years ago

I'm a fan of the slightly-less-partialized structure as well. Having the base stuff in the root of the sass folder helps people 1) find these key files quickly and 2) understand their relationship to the rest of the content-oriented partials.