Kimmie's LInk - Githubissues

Snugug / dib-boot

Grunt DIB boostrap

MIT License

1 stars 11 forks source link

Kimmie's LInk #5

Closed kimichimi closed 10 years ago

kimichimi commented 10 years ago

https://github.com/kimichimi/dib-boot/blob/kimmie/kimmie.html

Snugug commented 10 years ago

Hey, take a look at mine and see if you can improve your HTML semantics.

kimichimi commented 10 years ago

Thanks. I'm definitely going to take another stab at it.

kimichimi commented 10 years ago

@Snugug I worked on my homework and made a bunch of changes. However, the html isn't pushing to GitHub even though Terminal is showing "Nothing to Commit" My HTML as displayed in Github screen shot 2014-03-05 at 12 11 38 am

I'm not quite sure what i'm doing differently. What do you think?

Snugug commented 10 years ago

According to that screen shot, you've committed all of your changes. You now just need to push them to GitHub!

git push origin Kimmie

On Mar 5, 2014, at 3:12 AM, Kimmie Nguyen notifications@github.com wrote:

@Snugug I worked on my homework and made a bunch of changes. However, the html isn't pushing to GitHub even though Terminal is showing "Nothing to Commit"

![my actual html(https://f.cloud.github.com/assets/2780028/2330836/cdd68ad2-a43d-11e3-9840-0252354856a9.png)

I'm not quite sure what i'm doing differently. What do you think?

— Reply to this email directly or view it on GitHub.

Snugug commented 10 years ago

Did you get this pushed?

kimichimi commented 10 years ago

Hey. Sorry I can't: screen shot 2014-03-05 at 7 09 03 am

Snugug commented 10 years ago

Are you working from behind the firewall? Git won't work if you are. Did you follow the instructions to get your SSH key set up on GitHub so you can push?

kimichimi commented 10 years ago

I got it! w00t.

Snugug commented 10 years ago

A couple of things:

Be careful with your indentation
Tags should always be lowercase
Take a closer look at the <caption> element, you appear to be using it incorrectly
The content in your <footer> would probably be better served as <small>

kimichimi commented 10 years ago

Thanks for your help, @snugug. I made some changes.

From: Snugug [notifications@github.com] Sent: Wednesday, March 05, 2014 10:37 AM To: Snugug/dib-boot Cc: Nguyen, Kimmie (NBCUniversal) Subject: Re: [dib-boot] Kimmie's LInk (#5)

A couple of things:

Be careful with your indentation
Tags should always be lowercase
Take a closer look at the elementhttp://html5doctor.com/element-index/#caption, you appear to be using it incorrectly
The content in your
would probably be better served as http://html5doctor.com/element-index/#small

— Reply to this email directly or view it on GitHubhttps://github.com/Snugug/dib-boot/issues/5#issuecomment-36754593.

Snugug commented 10 years ago

Looks good!