SoCloz / SoclozMonitoringBundle

A profiling/monitoring Symfony2 bundle for production servers - alerts on exceptions, logs profiling data & sends data to statsd/graphite
MIT License
69 stars 6 forks source link

Guzzle dependency seems to be redundant in composer.json #21

Open nikita2206 opened 8 years ago

nikita2206 commented 8 years ago

After requiring monitoring-bundle in our composer.json we now have composer telling us that guzzle/guzzle is an abandoned package even though we don't use guzzle/guzzle at all:

Package guzzle/guzzle is abandoned, you should avoid using it. Use guzzlehttp/guzzle instead.

It seems like monitoring-bundle itself doesn't use guzzle as well, but it provides a plugin for it which can add RequestId to every request made with guzzle/guzzle (note it is not guzzlehttp/guzzle, which now contains a new version of guzzle). What I'd do in this case is add guzzle/guzzle to require-dev instead of require in composer.json so that it would be available for testing monitoring-bundle, but it would be completely optional for users of this bundle. Also it would be awesome (but out of scope of this issue) if this bundle supported bundles that integrate newer version of guzzle into Symfony, e.g.: eightpoints/guzzle-bundle, csa/guzzle-bundle and/or m6web/guzzle-http-bundle