SoCreate / angular-playground

A drop in app module for working on Angular components in isolation (Angular version 2.x and above).
http://www.angularplayground.it
MIT License
458 stars 62 forks source link

npm 8 dependency fails on outdated rxjs packages #299

Closed bendehghan closed 2 years ago

bendehghan commented 2 years ago

Angular 13 relies on rxjs 7 so playground should also move to that. But really all packages need updating to the next version.

Versions

angular 13

Repro steps

npm install fails without --legacy-peer-deps

Observed Behavior

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: angular-playground@8.2.0
npm WARN Found: rxjs@6.6.7
npm WARN node_modules/angular-playground/node_modules/rxjs
npm WARN   rxjs@"6.6.7" from @angular-devkit/core@12.2.15
npm WARN   node_modules/angular-playground/node_modules/@angular-devkit/core
npm WARN     @angular-devkit/core@"^12.0.0" from angular-playground@8.2.0
npm WARN     node_modules/angular-playground
npm WARN     2 more (@angular-devkit/schematics, @schematics/angular)
npm WARN   1 more (@angular-devkit/schematics)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer rxjs@">=6.6.0" from angular-playground@8.2.0
npm WARN node_modules/angular-playground
npm WARN   dev angular-playground@"8.2.0" from the root project
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: angular-playground@8.2.0
npm WARN Found: tslib@1.14.1
npm WARN node_modules/angular-playground/node_modules/tslib
npm WARN   tslib@"^1.9.0" from rxjs@6.6.7
npm WARN   node_modules/angular-playground/node_modules/rxjs
npm WARN     rxjs@"6.6.7" from @angular-devkit/core@12.2.15
npm WARN     node_modules/angular-playground/node_modules/@angular-devkit/core
npm WARN     1 more (@angular-devkit/schematics)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer tslib@">=2.1.0" from angular-playground@8.2.0
npm WARN node_modules/angular-playground
npm WARN   dev angular-playground@"8.2.0" from the root project

Desired Behavior

build without the warnings

Any other details that may be useful (optional)

lurock commented 2 years ago

I have updated all the dependencies.