Closed bendehghan closed 1 year ago
Hi @bendehghan
Thanks for reporting this. We would love to have you submit a pull request to fix this issue. Thank you!
I tried but had a hard time building the code I got from github. If you update the build instructions so that I can build it I can attempt to make the changes maybe. :) Maybe you're relying on some special shell commands I don't have.
$ npm run playground:build && npm run playground
> cli-example@0.0.0 playground:build
> (cd ../../ && sh ./scripts/build.sh)
sh: ./scripts/build.sh: No such file or directory
Any update on this? Where can I find file build.sh??
Thanks
Hey Ben,
If you download and install Cmder
https://github.com/cmderdev/cmder
That should have everything you need to build it. Sorry, I meant to send this to you the other day and I got pulled away in the middle of it
Thank you,
Justin Couto CEO @ SoCreate
From: Ben Dehghan @.> Sent: Tuesday, September 20, 2022 11:57:10 AM To: SoCreate/angular-playground @.> Cc: Justin Couto @.>; Comment @.> Subject: Re: [SoCreate/angular-playground] --check-visual-regressions not working in Jest 28 (Issue #314)
Any update on this? Where can I find file build.sh??
Thanks
— Reply to this email directly, view it on GitHubhttps://github.com/SoCreate/angular-playground/issues/314#issuecomment-1252780752, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGZQDYFXS62ASHZHLHJYYDV7ICINANCNFSM6AAAAAAQK3YFSI. You are receiving this because you commented.Message ID: @.***>
I'm on mac. This seems like a windows thing, no?
The issue I have is that your code is referring to
./scripts/build.sh
which is missing in the tree.
@bendehghan please take another look at the contribution instructions as I have updated them. https://github.com/SoCreate/angular-playground/blob/master/CONTRIBUTING.md
Ok. Here's the PR: https://github.com/SoCreate/angular-playground/pull/316
This is great. Thank you. Will you do a patch release for this?
Versions
Repro steps
Observed Behavior
The result is this:
Any other details that may be useful (optional)
I think the issue might be related to this: https://jestjs.io/docs/28.x/upgrading-to-jest28#jsdom which says that jest-environment-jsdom is needs to be installed separately in jest 28.
Incidentally Jest is now v29 but I haven't gotten to have it work so haven't tried playground with it either.