search

SoCuul / SCInsta

A feature-rich tweak for Instagram on iOS!
84 stars 14 forks source link

Activate GitHub workflow for online building of SCInsta IPA #28

Open zeuikli opened 2 months ago

zeuikli commented 2 months ago

Example : https://github.com/zeuikli/BHInsta/actions/runs/8732321318

Run workflow : CleanShot 2024-04-18 at 12 10 19@2x

Please enter the iOS SDK version and the IPA URL, then wait for the completion of the IPA build.

Build Status : CleanShot 2024-04-18 at 12 23 38@2x

Confirm that the IPA file can be installed via eSign, but note that the image download feature is still not functioning properly.

zeuikli commented 2 months ago

After the review, you can merge your commit into the main branch.

zeuikli commented 2 months ago

Update build.sh to fix the issue of IPA file not being found.

Added script commands to install pyzule.

Install pyzule

bash -c "$(curl https://raw.githubusercontent.com/asdfzxcvbn/pyzule/main/install-pyzule.sh)"

Modified the build.sh script by replacing certain instructions originally designated for BHInsta with those intended for SCInsta.

You can review my latest PR to verify these changes.

SoCuul commented 2 months ago

Update build.sh to fix the issue of IPA file not being found.

Added script commands to install pyzule. #Install pyzule bash -c "$(curl https://raw.githubusercontent.com/asdfzxcvbn/pyzule/main/install-pyzule.sh)"

Modified the build.sh script by replacing certain instructions originally designated for BHInsta with those intended for SCInsta.

You can review my latest PR to verify these changes.

It's super inefficient to install pyzule each time someone tries to build it, as they only need to install it once.

Could you just add it as another step in the buildapp workflow?

Also the build.sh functionality should be independant of the workflow. The workflow calls it from the repo folder, so it should work fine as-is.

zeuikli commented 2 months ago

Initially, you can proceed with the merge, but it's imperative to ensure that the "pyzule" tool is installed using GitHub Actions to facilitate the building of the IPA.

SoCuul commented 2 months ago

Initially, you can proceed with the merge, but it's imperative to ensure that the "pyzule" tool is installed using GitHub Actions to facilitate the building of the IPA.

I do not feel comfortable merging this into the main branch in its current state, as it would cause confusion for users who do not understand why the workflow fails on their end.

SoCuul commented 1 month ago

@zeuikli If you're working on this, what do you think about adding a dropdown in the workflow settings to select between sideloaded ipa, rootless and rootful

zeuikli commented 2 weeks ago

@SoCuul I have already updated the Github workflow and package dependencies to enable building IPA and deb files. You can review my pull request, but since your settings are for local builds, I recommend not merging my PR into the main branch. Instead, you can create another branch for GitHub Actions use cases.

SoCuul commented 2 weeks ago

@SoCuul I have already updated the Github workflow and package dependencies to enable building IPA and deb files. You can review my pull request, but since your settings are for local builds, I recommend not merging my PR into the main branch. Instead, you can create another branch for GitHub Actions use cases.

Thank you so much for your work! I'll take a look at the PR when I can.