search

SoMa-Project / ec_grasp_planner

Grasp Planner Based on Environmental Constraint Exploitation
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

Commented the code, changed the hybrid automatons for surface and wal… #1

Closed cerdogan closed 7 years ago

cerdogan commented 7 years ago

…l grasp, added/changed parameters

clemense commented 7 years ago

You deleted the "create_edge_grasp" method, why? This will create a run-time fault.

cerdogan commented 7 years ago

Regarding comment above, the edge grasp option is temporarily removed with 0cef8dc43aaf8cb6a55eb23dc80d3f78c696ace1 before further testing.

clemense commented 7 years ago

But wouldn't it make more sense to do this temporary fixing in a branch until it's done and only then pull into master? Rather than deleting things "temporarily" in master?

cerdogan commented 7 years ago

@clemense I would rather make sure everything in the master works and is reliable. I have not had a chance to test the edge grasp and I will add it back once we do.