search

SoMa-Project / ec_grasp_planner

Grasp Planner Based on Environmental Constraint Exploitation
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

Include naming fix of commit 4fae5d7 #59

Closed JannisW closed 5 years ago

JannisW commented 5 years ago

From: https://github.com/SoMa-Project/ec_grasp_planner/issues/58

> somehow the alternative_behavior does not have a field pre_grasp but pre_approach. Where can this naming difference come from?

This is probably a result from the merge in which at some point pre_grasp was renamed pre_approach in handarm_parameters and thus to avoid introducing the old name again (because of the new parameters) I had to change it in the feasibility node as well
This is surprising, because I thought I already changed it, but it does not appear to be in the commit... Whatever, the fix is easy. Just change 'pre_grasp' to 'pre_approach' for alternative_behavior
I'll also commit a fix in a second to the branch tub_ocado_merge_full

This PR merges the fix into master to make the checker usable!