search

SoMuchForSubtlety / f1viewer

🏎️ TUI for F1TV
GNU General Public License v3.0
758 stars 65 forks source link

Use ISO 639-2 language code and pass language settings to VLC #189

Closed nsunderland1 closed 3 years ago

nsunderland1 commented 3 years ago

Fixes #187

There are two changes in this PR:

As described in the linked issue, the default config uses en as the English-language code, when the 3-letter ISO 639-2 code is what's actually provided by F1TV. This leads to MPV choosing the default language for the stream instead. This PR changes the default config to use eng and overrides configs that use 2-letter ISO 639-1 codes.

The second change is to make the default VLC command use the user's preferred language. This doesn't seem to work for the fx track, might be that VLC is validating whether it's a real ISO code.

Tested these changes by verifying that MPV and VLC both stream in the correct language whether the short or long code is used. Tried this on streams that have English as the default (like most F1TV streams) and streams that have German as the default (as described in the linked issue). Also verified that the fx audio track isn't broken in MPV by this change.

SoMuchForSubtlety commented 3 years ago

I'll probably create a new release once #188 is also done.