SoPR / horas

Una plataforma para facilitar la mentoría.
1hora.org
MIT License
32 stars 17 forks source link

Search #64

Closed jpadilla closed 7 years ago

jpadilla commented 10 years ago

WIP attempt to fix #25. Implemented a custom manager with djorm-ext-pgfulltext to make use of PostgreSQL's unaccent function. The custom manager works well with sqlite on development, without having the unaccent function present. The manager implements "full-text" search for first and last name for now. Might be able to expand it to city, but not for tags(because they are available as a many to many relationship).

Check out the UserSearchModelTestCase for usage examples.

jpadilla commented 10 years ago

Failing test is unrelated to my work, but seemed to start failing late last night, possibly something with date/time issues?

gcollazo commented 10 years ago

@jpadilla Esos failing tests lo arreglé en master. Era un error en los tests como tal que inserté por error.

gcollazo commented 10 years ago

@jpadilla esto está ready?

jpadilla commented 10 years ago

@gcollazo yup, try it out. En los tests hay ejemplos de búsquedas.

gcollazo commented 10 years ago

@jpadilla,

Hice varias pruebas y pude notar que cuando hago un search sin usar city: o tags: no se toma en cuenta esos fields en la búsqueda.

Sugerencias para discutir:

froi commented 7 years ago

@jpadilla @gcollazo Should we try to resolve this issue?

jpadilla commented 7 years ago

@froi not worth it as is, we can tackle this later if we want.