search

SoPR / horas

Una plataforma para facilitar la mentoría.
1hora.org
MIT License
32 stars 17 forks source link

Dockerize project #83

Closed froi closed 7 years ago

froi commented 7 years ago

Hey guys!

These changes resolve #78. They aren't yet complete but I figured that starting to look at them wouldn't hurt.

IMO the changes that are left is to get Brunch working and update the README with a Docker section.

Thoughts?

froi commented 7 years ago

Decided not to get brunch working in the container. I'd rather add some volumes and have the user execute the commands on his local machine. This will keep the image simpler and smaller in size.

Having a volume will make developing with the image better. You won't have to constantly copy the source to the container.

jpadilla commented 7 years ago

Hablando de brunch, I vote for @gcollazo to switch all that for a nicer setup with webpack.

froi commented 7 years ago

@jpadilla Sure. Let's create a new issue with that. I wouldn't do it here.

gcollazo commented 7 years ago

Yeah yo puedo hacer eso.

froi commented 7 years ago

@jpadilla @gcollazo can you guys give this a look before we merge. Thanks!