search

SoapSeller / omniauth-facebook-access-token

51 stars 68 forks source link

Fix SSL to last version available #11

Closed viniciusnz closed 10 years ago

viniciusnz commented 10 years ago

Facebook just disabled SSLv3 due to security failures found on the protocol. See http://googleonlinesecurity.blogspot.com.br/2014/10/this-poodle-bites-exploiting-ssl-30.html

SoapSeller commented 10 years ago

Hi @viniciusnz,

Setting TLS1.2 doesn't seem to work on my machine, I merged another PR(#12) that seems to do the trick.

Thanks,

viniciusnz commented 10 years ago

This should have been TLSv1_2 according to openssl, but openssl SSLv23 is a better option. I thought it was the one that i had suggested on the branch i created (i think i may have pull requested for the master instead of the right branch). All is good with pr #12... Tks!

Vinicius Ferriani +55-11-952590002

On Oct 15, 2014, at 9:15 PM, SoapSeller notifications@github.com wrote:

Hi @viniciusnz https://github.com/viniciusnz,

Setting TLS1.2 doesn't seem to work on my machine, I merged another PR(#12 https://github.com/SoapSeller/omniauth-facebook-access-token/pull/12) that seems to do the trick.

Thanks,

— Reply to this email directly or view it on GitHub https://github.com/SoapSeller/omniauth-facebook-access-token/pull/11#issuecomment-59296850 .