search

SoapSeller / omniauth-facebook-access-token

51 stars 68 forks source link

Support image dimension using the image_size option #8

Closed chrisbrant closed 10 years ago

chrisbrant commented 10 years ago

Updated image_size option to maintain compatibility with omniauth-facebook. See related commit here.

SoapSeller commented 10 years ago

@chrisbrant, Sorry for the delay, I want to merge this, is the last commit here(671fda6) is required?

pdobb commented 10 years ago

@SoapSeller I did notice that when trying to install omniauth-facebook-access-token next to omniauth-facebook there is a dependency conflict:

Bundler could not find compatible versions for gem "oauth2":
  In Gemfile:
    omniauth-facebook-access-token (>= 0) ruby depends on
      oauth2 (~> 0.8.0) ruby

    omniauth-facebook (>= 0) ruby depends on
      oauth2 (0.9.4)

So the proposed dependency change makes sense in that regard.

SoapSeller commented 10 years ago

@pdobb, thanks.

I've merged this pull-request and published a new version.