Soaryn / XyCraftTracker

Public issue tracker
4 stars 0 forks source link

[Bug]: Possible EMI compat issue #63

Closed Saereth closed 3 weeks ago

Saereth commented 3 weeks ago

Mod Title

XyCraft Machines

Minecraft Version

1.21.0

Severity

Crashing

NeoForge Version

Mc 1.21.1 Neoforge: 21.1.22

Describe the Suggestion

I opened an issue with EMI as well as I'm not quite sure where the issue lies; https://github.com/emilyploszaj/emi/issues/674

Reproduction Steps

mc: 1.21.1 Neoforge: 21.1.22 JEI: jei-1.21.1-neoforge-19.8.4.113 EMI: emi-1.1.11+1.21+neoforge Stellaris: stellaris-1.21-neoforge-1.0.5 Xycraft: xycraft_core-0.7.45-all xycraft_machines-0.7.45 xycraft_world-0.7.45

So what happens is when you search for oil in EMI the game crashes. If I remove stellaris it's fine but I dont have any other mods that add a liquid to know if its related to stellaris at all (I suspect not as we've had a similar crash searching for tritium with mekanism in the pack). Adding the xycraft mods along with EMi causes the crash to occur. Without Xycraft the crash doesnt occur and using JEI alone without EMI will cause the crash not to occur.

Here is the crash log

https://mclo.gs/NlmXqzM

Screenshots and Videos

No response

Additional Context

No response

Soaryn commented 3 weeks ago

No idea what is happening there, our flhids dont do anything spectacular or custom really. I have an "Oil" registered, but that shouldnt be causing issues here. What is stellaris?

Soaryn commented 3 weeks ago

Curiously, what does the creative tab look like for XyCraft foils without emi? I Think Stellaris may have a broken fluid as the crash seems to be when a foil (fluid container) is rendering. However, that wouldnt explain EMI unless it lists foils with fluids in them. (It doesnt in JEI)

Soaryn commented 3 weeks ago

Notes put on the EMI issue page, but will note them here as well: This is a Stellaris (and likely an Architectury) bug: image A fluid texture SHOULD be present as per the documentation.

image

For reference, this would also happen with Mekanism + Stellaris with their tanks when they go to grab the fluid texture

Saereth commented 3 weeks ago

took this over to the stellaris devs, thanks for checking in on it