search

Sobesednik / node-exiftool

A Node.js interface to exiftool command-line application.
MIT License
91 stars 15 forks source link

Fix for "Command with the same number is already expected" #26

Closed redhelling21 closed 7 years ago

redhelling21 commented 7 years ago

When starting a large number of commands (>2000), the same command number is sometimes generated twice. This fixes the error by providing a real unique number for each command

z-vr commented 7 years ago

@redhelling21 Hi, thanks for the request. I'm not a big fun of functions leaking something to the scope of the whole file, could you find another way to generate random ids? e.g., increate the order by 10 or a 100

redhelling21 commented 7 years ago

That's what I did at first, but the problem is still here : if you increase the order by 10, the bug will just happen when an increased number of files are read... So yes, it is a temporary fix, but not a definitive one.

z-vr commented 7 years ago

@redhelling21 hey dude you can use node-exiftool@2.1.5 now, I've merged your PR, thanks 👍