search

Sochettra / dynatree

Automatically exported from code.google.com/p/dynatree
0 stars 0 forks source link

Use event.preventDefault in onClick handlers #181

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
In dynatree 1.1 version there is a line with comment 

// Make sure that clicks stop, otherwise <a href='#'> jumps to the top
return false;

This will stop event propagation completely, but you just want to disable 
default link behaviour, so event.preventDefault() should be used instead of 
return false;

The same for _onKeydown

Original issue reported on code.google.com by BET...@gmail.com on 17 Feb 2011 at 5:06

GoogleCodeExporter commented 8 years ago

Original comment by moo...@wwwendt.de on 17 Feb 2011 at 7:21

GoogleCodeExporter commented 8 years ago 
This issue was closed by revision r465.

Original comment by moo...@wwwendt.de on 17 Feb 2011 at 7:24

GoogleCodeExporter commented 8 years ago 
considered verified

Original comment by moo...@wwwendt.de on 17 Jul 2012 at 4:16

GoogleCodeExporter commented 8 years ago

Original comment by moo...@wwwendt.de on 17 Jul 2012 at 4:19