Sochettra / dynatree

Automatically exported from code.google.com/p/dynatree
0 stars 0 forks source link

Make Dynatree Init and Cookie console logging conform to debugLevel option #242

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What new or enhanced feature are you proposing?
Please make the console logs for initializing the Dynatree and also the console 
logging of cookie saving / loading conform to the debugLevel option.
Even on debugLevel 0, these logs are still produced.

What goal would this enhancement help you achieve?
This would not only create less "visual polution" on the console.log but would 
increase performance when saving / loading a cookie, since logging slows down 
performance, especially if we load/save a lot of cookies at the same time (for 
example I have a custom dynatree solution where shift clicking selects more 
than one node at the same time, and if we log a 'cookie saved' once for each of 
this nodes, it slows down performance a lot...)

By the way, thanks for such an AWESOME widget :)

Original issue reported on code.google.com by vitorbal@gmail.com on 24 Oct 2011 at 4:00

GoogleCodeExporter commented 8 years ago

Original comment by moo...@wwwendt.de on 24 Oct 2011 at 6:51

GoogleCodeExporter commented 8 years ago
Using 1.2.0 I only see 
    Dynatree._create(): version='$Version: 1.2.0$', debugLevel=1.
in the example browser ('Persistence' sample).
Can you give some more info please?

Original comment by moo...@wwwendt.de on 25 Oct 2011 at 5:36

GoogleCodeExporter commented 8 years ago
Hi, you are right, with 1.2.0 the loggings are not showing anymore with 
debugLevel 0.
You can close this, I apologize for the mistake.

Original comment by vitorbal@gmail.com on 31 Oct 2011 at 10:28

GoogleCodeExporter commented 8 years ago
no problem, thanks for the feedback.

Original comment by moo...@wwwendt.de on 1 Nov 2011 at 6:39