search

SocialCognitiveSystems / PRIMO

GNU Lesser General Public License v3.0
4 stars 3 forks source link

Change node name #16

Closed jpoeppel closed 6 years ago

jpoeppel commented 6 years ago

The GUI allows changing the name of nodes (especially when creating new graphs from scratch) which needs to be supported by Primo. As Primo internally uses actual node objects and their names interchangeably, special care needs to be taken when changing a node. This PR hopefully changes all relevant parts on the network side. Any inference structures (especially factor tree!) will obviously have to be recreated after changing a name.

hbuschme commented 6 years ago

Ok, my comment at #15 concerning the #Todo style comment can be ignored. I guess I just find these multiple pull-requests confusing. I guess it would be best to merge them in the correct order. So please respond to my comments on #14 and #15 and then I will merge.

jpoeppel commented 6 years ago

Was just my mistake to have part of this PR in #15. But yeah 15 should be merged before this one to prevent conflicts.