SocialEngine / phpv4-feature-requests

The purpose of this repository is to collect SocialEngine PHP public feature requests.
https://www.socialengine.com
1 stars 0 forks source link

Some CSS is missing from the Mobile module #108

Open DonnaScriptTechs opened 7 years ago

DonnaScriptTechs commented 7 years ago

From @Mthorganby on April 29, 2017 19:1

PHP 4.91 core module Mobile When you install it out the box, some css is missing.

On the "mobile browse page" lines <li>are missing the height.

.browse_menu>ul>li {
    display: block;
    border-bottom: 1px solid #d8dbe2;
    line-height: 60px !important;                 /*missing */
    font-size: 20px !important;                    /* optional, but looks better */
    font-weight: 700 !important;                 /* optional, but looks better */
}

Copied from original issue: SocialEngine/phpv4-issues#722

DonnaScriptTechs commented 7 years ago

From @Elshara on April 30, 2017 14:31

Yes it is missing.

On 29/04/2017, Mthorganby notifications@github.com wrote:

PHP 4.91 core module Mobile When you install it out the box, some css is missing.

On the "browse page" some of the lines

  • are missing the height.

    .browse_menu>ul>li { display: block; border-bottom: 1px solid #d8dbe2; line-height: 60px !important; /missing / font-size: 20px !important; / optional, but looks better / font-weight: 700 !important; / optional, but looks better / }

    -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/SocialEngine/phpv4-issues/issues/722

  • DonnaScriptTechs commented 7 years ago

    I'm not sure if it was done intentionally as that height change on my iPhone 5c makes the list way too long with a lot of empty space. However, I'll leave this open for @Khushboo016 to see as I'm not a CSS expert. Noting that we have to accommodate a lot of different screen sizes. :)

    DonnaScriptTechs commented 7 years ago

    From @Mthorganby on May 3, 2017 16:53

    @DonnaScriptTechs try a lower line-height: 40px I did line-height: 60px as I got fat fingers and i am not as advanced as you are...still using iPhone 4S latest iOS tho :)

    DonnaScriptTechs commented 7 years ago

    lol that was fun. :) I'll let Khushboo check this as she's got the CSS expertise. I don't know all of the various devices we might have to deal with and why it was done like it has been. Perhaps it is the best way for other devices to be able to view it and so we leave it for the clients to adjust as they wish (for fat fingers and well seasoned devices :) )

    DonnaScriptTechs commented 7 years ago

    From @Khushboo016 on May 12, 2017 12:7

    Hi @Mthorganby, Thanks for the suggestion! We've checked this issue at our end and after adding the "line-height" attribute to the CSS code, the "Mobile Browse Page" looks better, so we are adding your suggestion as an enhancement.

    Thanks & Regards!

    DonnaScriptTechs commented 7 years ago

    From @Mthorganby on May 12, 2017 13:6

    Hi @Khushboo016 thanks !! Are you doing the CSS @Khushboo016 ?