SocialFinanceDigitalLabs / cs-demand-model-regional

CS Demand Model webapp for regional analysis
MIT License
0 stars 1 forks source link

104 cost page error #105

Closed amynickolls closed 1 month ago

amynickolls commented 1 month ago

placement_proportion_table was throwing an error due to historic and forecast proportions not being the same size - fixed via align/left join and fill (forecast proportions will always have ALL subcategories for any placementcategory in the historic data, but historic proportions only outputs the subcategories in historic data)

From here realised that costs has an error - subcategories not in data should be assigned 0 but this wasn't accounted for, has been adjusted.

Also renamed some proportions variables to increase code readability