SocialGouv / domifa

Faciliter l'accès aux droits pour les personnes sans domicile stable, en simplifiant la gestion de la domiciliation
https://domifa.fabrique.social.gouv.fr
Apache License 2.0
14 stars 10 forks source link

Refactor common #3291

Closed pYassine closed 2 months ago

socket-security[bot] commented 2 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/object-assign@4.1.1

View full report↗︎

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 48.50746% with 69 lines in your changes are missing coverage. Please review.

Project coverage is 67.14%. Comparing base (bd6630a) to head (4bb4695). Report is 2 commits behind head on master.

:exclamation: Current head 4bb4695 differs from pull request most recent head a6739f0. Consider uploading reports for the commit a6739f0 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/SocialGouv/domifa/pull/3291/graphs/tree.svg?width=650&height=150&src=pr&token=ydhKiPXRFO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv)](https://app.codecov.io/gh/SocialGouv/domifa/pull/3291?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) ```diff @@ Coverage Diff @@ ## master #3291 +/- ## ========================================== - Coverage 67.34% 67.14% -0.20% ========================================== Files 889 894 +5 Lines 14705 14812 +107 Branches 2105 2128 +23 ========================================== + Hits 9903 9946 +43 - Misses 4642 4693 +51 - Partials 160 173 +13 ``` | [Files](https://app.codecov.io/gh/SocialGouv/domifa/pull/3291?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) | Coverage Δ | | |---|---|---| | [...kend/src/\_common/mocks/usagers/POST\_USAGER.mock.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3291?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2F_common%2Fmocks%2Fusagers%2FPOST_USAGER.mock.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvX2NvbW1vbi9tb2Nrcy91c2FnZXJzL1BPU1RfVVNBR0VSLm1vY2sudHM=) | `100.00% <ø> (ø)` | | | [...end/src/\_common/mocks/usagers/USAGER\_REFUS.mock.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3291?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2F_common%2Fmocks%2Fusagers%2FUSAGER_REFUS.mock.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvX2NvbW1vbi9tb2Nrcy91c2FnZXJzL1VTQUdFUl9SRUZVUy5tb2NrLnRz) | `100.00% <100.00%> (ø)` | | | [...nd/src/\_common/mocks/usagers/USAGER\_VALIDE.mock.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3291?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2F_common%2Fmocks%2Fusagers%2FUSAGER_VALIDE.mock.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvX2NvbW1vbi9tb2Nrcy91c2FnZXJzL1VTQUdFUl9WQUxJREUubW9jay50cw==) | `100.00% <ø> (ø)` | | | [packages/backend/src/\_common/model/usager/index.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3291?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2F_common%2Fmodel%2Fusager%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvX2NvbW1vbi9tb2RlbC91c2FnZXIvaW5kZXgudHM=) | `100.00% <ø> (ø)` | | | [...s/\_init-db/1603812391580-pr-env-create-database.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3291?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2F_migrations%2F_init-db%2F1603812391580-pr-env-create-database.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvX21pZ3JhdGlvbnMvX2luaXQtZGIvMTYwMzgxMjM5MTU4MC1wci1lbnYtY3JlYXRlLWRhdGFiYXNlLnRz) | `21.05% <ø> (ø)` | | | [...c/auth/decorators/current-usager-note.decorator.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3291?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fauth%2Fdecorators%2Fcurrent-usager-note.decorator.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvYXV0aC9kZWNvcmF0b3JzL2N1cnJlbnQtdXNhZ2VyLW5vdGUuZGVjb3JhdG9yLnRz) | `100.00% <ø> (ø)` | | | [...nd/src/auth/decorators/current-usager.decorator.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3291?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fauth%2Fdecorators%2Fcurrent-usager.decorator.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvYXV0aC9kZWNvcmF0b3JzL2N1cnJlbnQtdXNhZ2VyLmRlY29yYXRvci50cw==) | `100.00% <ø> (ø)` | | | [...ges/backend/src/auth/guards/usager-access.guard.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3291?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fauth%2Fguards%2Fusager-access.guard.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvYXV0aC9ndWFyZHMvdXNhZ2VyLWFjY2Vzcy5ndWFyZC50cw==) | `89.47% <ø> (ø)` | | | [...ntities/usager/UsagerHistoryStatesTable.typeorm.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3291?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fdatabase%2Fentities%2Fusager%2FUsagerHistoryStatesTable.typeorm.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvZGF0YWJhc2UvZW50aXRpZXMvdXNhZ2VyL1VzYWdlckhpc3RvcnlTdGF0ZXNUYWJsZS50eXBlb3JtLnRz) | `100.00% <100.00%> (ø)` | | | [...tabase/entities/usager/UsagerNotesTable.typeorm.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3291?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fdatabase%2Fentities%2Fusager%2FUsagerNotesTable.typeorm.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvZGF0YWJhc2UvZW50aXRpZXMvdXNhZ2VyL1VzYWdlck5vdGVzVGFibGUudHlwZW9ybS50cw==) | `100.00% <ø> (ø)` | | | ... and [78 more](https://app.codecov.io/gh/SocialGouv/domifa/pull/3291?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) | | ... and [92 files with indirect coverage changes](https://app.codecov.io/gh/SocialGouv/domifa/pull/3291/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/SocialGouv/domifa/pull/3291?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/SocialGouv/domifa/pull/3291?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv). Last update [bd6630a...a6739f0](https://app.codecov.io/gh/SocialGouv/domifa/pull/3291?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv).
socket-security[bot] commented 2 months ago

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

github-actions[bot] commented 2 months ago

🎉 Deployment for commit 4bb469519c794d3deb8b0bf9ce533a51b876a122 :

Ingresses - 🚀 [https://admin-domifa-refactor-common.ovh.fabrique.social.gouv.fr/](https://admin-domifa-refactor-common.ovh.fabrique.social.gouv.fr/) - 🚀 [https://api-domifa-refactor-common.ovh.fabrique.social.gouv.fr/](https://api-domifa-refactor-common.ovh.fabrique.social.gouv.fr/) - 🚀 [https://domifa-refactor-common.ovh.fabrique.social.gouv.fr/](https://domifa-refactor-common.ovh.fabrique.social.gouv.fr/) - 🚀 [https://mon-domifa-refactor-common.ovh.fabrique.social.gouv.fr/](https://mon-domifa-refactor-common.ovh.fabrique.social.gouv.fr/)
Docker images - 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-4bb469519c794d3deb8b0bf9ce533a51b876a122 - 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-4bb469519c794d3deb8b0bf9ce533a51b876a122 - 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-4bb469519c794d3deb8b0bf9ce533a51b876a122 - 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-4bb469519c794d3deb8b0bf9ce533a51b876a122
Debug - [📕 Loki logs for namespace domifa-refactor-common](https://grafana-ovh.fabrique.social.gouv.fr/explore?orgId=1&left=%5B%22now-6h%22,%22now%22,%22Loki%22,%7B%22expr%22:%22%7Bnamespace%3D%5C%22domifa-refactor-common%5C%22%7D%22%7D%5D) - [📈 Pods monitoring for namespace domifa-refactor-common](https://grafana-ovh.fabrique.social.gouv.fr/d/a7df53d7-0696-4e00-821b-c56b66e5c20a/kubernetes-compute-resources-namespace-pods?orgId=1&refresh=10s&var-datasource=P5DCFC7561CCDE821&var-cluster=ovh-dev&var-namespace=domifa-refactor-common) - [📈 Workloads monitoring for namespace domifa-refactor-common](https://grafana-ovh.fabrique.social.gouv.fr/d/a164a7f0339f99e89cea5cb47e9be617V2/kubernetes-compute-resources-namespace-workloads?orgId=1&refresh=10s&var-datasource=eb239be0-0ac2-41d5-9e1a-061f951a07a3&var-cluster=ovh-dev&var-namespace=domifa-refactor-common&var-type=deployment) - [🐘 CNPG pg](https://grafana-ovh.fabrique.social.gouv.fr/d/z7FCA4Nn1/cloudnativepg?orgId=1&refresh=30s&var-DS_PROMETHEUS=default&var-namespace=domifa-refactor-common&var-cluster=pg&var-instances=All)
github-advanced-security[bot] commented 2 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.5% Duplication on New Code

See analysis details on SonarCloud

SocialGroovyBot commented 2 months ago

:tada: This PR is included in version 2.166.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: