SocialGouv / domifa

Faciliter l'accès aux droits pour les personnes sans domicile stable, en simplifiant la gestion de la domiciliation
https://domifa.fabrique.social.gouv.fr
Apache License 2.0
14 stars 10 forks source link

Feat refactor store frontend #3454

Closed pYassine closed 3 months ago

codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 62.08531% with 80 lines in your changes missing coverage. Please review.

Project coverage is 66.68%. Comparing base (6fa8b47) to head (80382ab). Report is 5 commits behind head on master.

Files Patch % Lines
...nage-usagers-page/manage-usagers-page.component.ts 30.00% 21 Missing :warning:
.../services/calculateUsagersCountByStatus.service.ts 9.09% 10 Missing :warning:
.../manage-usagers/services/manage-usagers.service.ts 16.66% 10 Missing :warning:
...es/usager-profil/services/usager-profil.service.ts 28.57% 5 Missing :warning:
...app/shared/store/usager-actions-reducer.service.ts 89.13% 5 Missing :warning:
.../usager-dossier/services/usager-dossier.service.ts 42.85% 4 Missing :warning:
...s/usager-profil/services/usager-options.service.ts 33.33% 4 Missing :warning:
.../modules/usager-shared/services/usagers.service.ts 33.33% 4 Missing :warning:
...ules/usager-notes/services/usager-notes.service.ts 50.00% 3 Missing :warning:
...nd/src/app/modules/shared/services/auth.service.ts 50.00% 2 Missing :warning:
... and 8 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/SocialGouv/domifa/pull/3454/graphs/tree.svg?width=650&height=150&src=pr&token=ydhKiPXRFO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv)](https://app.codecov.io/gh/SocialGouv/domifa/pull/3454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) ```diff @@ Coverage Diff @@ ## master #3454 +/- ## ========================================== + Coverage 66.47% 66.68% +0.21% ========================================== Files 922 922 Lines 15214 15188 -26 Branches 2130 2132 +2 ========================================== + Hits 10113 10128 +15 + Misses 5061 5020 -41 Partials 40 40 ``` | [Files](https://app.codecov.io/gh/SocialGouv/domifa/pull/3454?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) | Coverage Δ | | |---|---|---| | [...in-structures/services/admin-structures.service.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3454?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2F_portail-admin%2Fadmin-structures%2Fservices%2Fadmin-structures.service.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvX3BvcnRhaWwtYWRtaW4vYWRtaW4tc3RydWN0dXJlcy9zZXJ2aWNlcy9hZG1pbi1zdHJ1Y3R1cmVzLnNlcnZpY2UudHM=) | `98.51% <ø> (ø)` | | | [packages/backend/src/auth/auth.module.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3454?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fauth%2Fauth.module.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvYXV0aC9hdXRoLm1vZHVsZS50cw==) | `100.00% <ø> (ø)` | | | [...usagers/controllers/usagers-decision.controller.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3454?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fusagers%2Fcontrollers%2Fusagers-decision.controller.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvdXNhZ2Vycy9jb250cm9sbGVycy91c2FnZXJzLWRlY2lzaW9uLmNvbnRyb2xsZXIudHM=) | `43.10% <ø> (ø)` | | | [...kend/src/usagers/controllers/usagers.controller.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3454?src=pr&el=tree&filepath=packages%2Fbackend%2Fsrc%2Fusagers%2Fcontrollers%2Fusagers.controller.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvYmFja2VuZC9zcmMvdXNhZ2Vycy9jb250cm9sbGVycy91c2FnZXJzLmNvbnRyb2xsZXIudHM=) | `64.66% <100.00%> (-0.27%)` | :arrow_down: | | [...es/frontend/src/\_common/mocks/USAGER\_REFUS.mock.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3454?src=pr&el=tree&filepath=packages%2Ffrontend%2Fsrc%2F_common%2Fmocks%2FUSAGER_REFUS.mock.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvZnJvbnRlbmQvc3JjL19jb21tb24vbW9ja3MvVVNBR0VSX1JFRlVTLm1vY2sudHM=) | `100.00% <ø> (ø)` | | | [...s/frontend/src/\_common/mocks/USAGER\_VALIDE.mock.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3454?src=pr&el=tree&filepath=packages%2Ffrontend%2Fsrc%2F_common%2Fmocks%2FUSAGER_VALIDE.mock.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvZnJvbnRlbmQvc3JjL19jb21tb24vbW9ja3MvVVNBR0VSX1ZBTElERS5tb2NrLnRz) | `100.00% <100.00%> (ø)` | | | [packages/frontend/src/\_common/mocks/index.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3454?src=pr&el=tree&filepath=packages%2Ffrontend%2Fsrc%2F_common%2Fmocks%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvZnJvbnRlbmQvc3JjL19jb21tb24vbW9ja3MvaW5kZXgudHM=) | `100.00% <100.00%> (ø)` | | | [packages/frontend/src/app/app.module.ts](https://app.codecov.io/gh/SocialGouv/domifa/pull/3454?src=pr&el=tree&filepath=packages%2Ffrontend%2Fsrc%2Fapp%2Fapp.module.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvZnJvbnRlbmQvc3JjL2FwcC9hcHAubW9kdWxlLnRz) | `93.33% <100.00%> (-0.22%)` | :arrow_down: | | [...ge-usagers-page/manage-usagers-page.component.html](https://app.codecov.io/gh/SocialGouv/domifa/pull/3454?src=pr&el=tree&filepath=packages%2Ffrontend%2Fsrc%2Fapp%2Fmodules%2Fmanage-usagers%2Fcomponents%2Fmanage-usagers-page%2Fmanage-usagers-page.component.html&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvZnJvbnRlbmQvc3JjL2FwcC9tb2R1bGVzL21hbmFnZS11c2FnZXJzL2NvbXBvbmVudHMvbWFuYWdlLXVzYWdlcnMtcGFnZS9tYW5hZ2UtdXNhZ2Vycy1wYWdlLmNvbXBvbmVudC5odG1s) | `100.00% <ø> (ø)` | | | [...nts/manage-usagers-table/manage-usagers-table.html](https://app.codecov.io/gh/SocialGouv/domifa/pull/3454?src=pr&el=tree&filepath=packages%2Ffrontend%2Fsrc%2Fapp%2Fmodules%2Fmanage-usagers%2Fcomponents%2Fmanage-usagers-table%2Fmanage-usagers-table.html&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-cGFja2FnZXMvZnJvbnRlbmQvc3JjL2FwcC9tb2R1bGVzL21hbmFnZS11c2FnZXJzL2NvbXBvbmVudHMvbWFuYWdlLXVzYWdlcnMtdGFibGUvbWFuYWdlLXVzYWdlcnMtdGFibGUuaHRtbA==) | `100.00% <ø> (ø)` | | | ... and [48 more](https://app.codecov.io/gh/SocialGouv/domifa/pull/3454?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/SocialGouv/domifa/pull/3454/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/SocialGouv/domifa/pull/3454?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/SocialGouv/domifa/pull/3454?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv). Last update [6fa8b47...80382ab](https://app.codecov.io/gh/SocialGouv/domifa/pull/3454?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv).
github-advanced-security[bot] commented 3 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 3 months ago

🎉 Deployment for commit 80382abefa713f0c833838ce0cd315efd6703f57 :

Ingresses - 🚀 [https://admin-domifa-feat-refactor-store-frontend.ovh.fabrique.social.gouv.fr/](https://admin-domifa-feat-refactor-store-frontend.ovh.fabrique.social.gouv.fr/) - 🚀 [https://api-domifa-feat-refactor-store-frontend.ovh.fabrique.social.gouv.fr/](https://api-domifa-feat-refactor-store-frontend.ovh.fabrique.social.gouv.fr/) - 🚀 [https://api-domifa-feat-refactor-store-frontend.ovh.fabrique.social.gouv.fr/admin/structures/export](https://api-domifa-feat-refactor-store-frontend.ovh.fabrique.social.gouv.fr/admin/structures/export) - 🚀 [https://api-domifa-feat-refactor-store-frontend.ovh.fabrique.social.gouv.fr/export](https://api-domifa-feat-refactor-store-frontend.ovh.fabrique.social.gouv.fr/export) - 🚀 [https://api-domifa-feat-refactor-store-frontend.ovh.fabrique.social.gouv.fr/stats](https://api-domifa-feat-refactor-store-frontend.ovh.fabrique.social.gouv.fr/stats) - 🚀 [https://api-domifa-feat-refactor-store-frontend.ovh.fabrique.social.gouv.fr/stats/home](https://api-domifa-feat-refactor-store-frontend.ovh.fabrique.social.gouv.fr/stats/home) - 🚀 [https://domifa-feat-refactor-store-frontend.ovh.fabrique.social.gouv.fr/](https://domifa-feat-refactor-store-frontend.ovh.fabrique.social.gouv.fr/) - 🚀 [https://mon-domifa-feat-refactor-store-frontend.ovh.fabrique.social.gouv.fr/](https://mon-domifa-feat-refactor-store-frontend.ovh.fabrique.social.gouv.fr/)
Docker images - 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-80382abefa713f0c833838ce0cd315efd6703f57 - 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-80382abefa713f0c833838ce0cd315efd6703f57 - 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-80382abefa713f0c833838ce0cd315efd6703f57 - 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-80382abefa713f0c833838ce0cd315efd6703f57
Debug - [📕 Loki logs for namespace domifa-feat-refactor-store-frontend](https://grafana-ovh.fabrique.social.gouv.fr/explore?orgId=1&left=%5B%22now-6h%22,%22now%22,%22Loki%22,%7B%22expr%22:%22%7Bnamespace%3D%5C%22domifa-feat-refactor-store-frontend%5C%22%7D%22%7D%5D) - [📈 Pods monitoring for namespace domifa-feat-refactor-store-frontend](https://grafana-ovh.fabrique.social.gouv.fr/d/a7df53d7-0696-4e00-821b-c56b66e5c20a/kubernetes-compute-resources-namespace-pods?orgId=1&refresh=10s&var-datasource=P5DCFC7561CCDE821&var-cluster=ovh-dev&var-namespace=domifa-feat-refactor-store-frontend) - [📈 Workloads monitoring for namespace domifa-feat-refactor-store-frontend](https://grafana-ovh.fabrique.social.gouv.fr/d/a164a7f0339f99e89cea5cb47e9be617V2/kubernetes-compute-resources-namespace-workloads?orgId=1&refresh=10s&var-datasource=eb239be0-0ac2-41d5-9e1a-061f951a07a3&var-cluster=ovh-dev&var-namespace=domifa-feat-refactor-store-frontend&var-type=deployment) - [🐘 CNPG pg](https://grafana-ovh.fabrique.social.gouv.fr/d/z7FCA4Nn1/cloudnativepg?orgId=1&refresh=30s&var-DS_PROMETHEUS=default&var-namespace=domifa-feat-refactor-store-frontend&var-cluster=pg&var-instances=All)
SocialGroovyBot commented 3 months ago

:tada: This PR is included in version 2.173.25 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: