search

SocialGouv / kosko-charts

The Social Gouv Kosko Charts
http://socialgouv.github.io/kosko-charts
Apache License 2.0
9 stars 2 forks source link

kosko4 + subdomain #316

Closed revolunet closed 3 years ago

revolunet commented 3 years ago

Looks like the config.subdomain is not active anymore.

The prod snapshot here should create the ingress with that subdomain but it doesnt : https://github.com/SocialGouv/archifiltre-site/pull/112

revolunet commented 3 years ago

A priori c'est dû au merge ici, sur lequel gitlab override la config user

https://github.com/SocialGouv/kosko-charts/blob/alpha/src/components/app/index.ts#L69

douglasduteil commented 3 years ago

🤔 it's overridden by gitlab(process.env) ?

douglasduteil commented 3 years ago

We should write a test case to ensure this

revolunet commented 3 years ago

yes; ive added a snapshot in #317

revolunet commented 3 years ago

fixed in upcoming v4