search

SocialGouv / kosko-charts

The Social Gouv Kosko Charts
http://socialgouv.github.io/kosko-charts
Apache License 2.0
9 stars 2 forks source link

fix(slug): Reduce slug size from 63 to 53 chars #799

Closed gary-van-woerkens closed 3 years ago

gary-van-woerkens commented 3 years ago

Trying to avoid too long subdomain problem.

Example:

Note that the Gitlab CI documentation says (https://docs.gitlab.com/14.4/ee/ci/variables/predefined_variables.html): CI_ENVIRONMENT_SLUG: The simplified version of the environment name, suitable for inclusion in DNS, URLs, Kubernetes labels, and so on. Available if environment:name is set. The slug is truncated to 24 characters.

But a ticket linked to the doc talks about 63 chars: https://gitlab.com/gitlab-org/gitlab/-/issues/20941

codecov-commenter commented 3 years ago

Codecov Report

Merging #799 (15d53cb) into master (bcdc43a) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #799   +/-   ##
=======================================
  Coverage   80.92%   80.92%           
=======================================
  Files          54       54           
  Lines         519      519           
  Branches      151      151           
=======================================
  Hits          420      420           
  Misses         66       66           
  Partials       33       33
Impacted Files Coverage Δ
src/components/app/index.ts 57.14% <100.00%> (ø)
src/utils/environmentSlug.ts 86.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bcdc43a...15d53cb. Read the comment docs.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 9.6.22 :tada:

The release is available on:

Your semantic-release bot :package::rocket: