search

SocialGouv / kosko-charts

The Social Gouv Kosko Charts
http://socialgouv.github.io/kosko-charts
Apache License 2.0
9 stars 2 forks source link

subdomain naming #866

Open revolunet opened 2 years ago

revolunet commented 2 years ago

RFC 1123 

Invalid value: "hasura-carnet-de-bord-lionelb-handle-form-validation-.dev.fabrique.social.gouv.fr": 
a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.' 
and must start and end with an alphanumeric character
 (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

https://github.com/SocialGouv/kosko-charts/blob/master/src/components/app/index.ts#L191

It happens when a subDomainPrefix (ex: hasura-) is added to the existing branch-slug-hash

Options :