search

SocialGouv / matomo-next

Matomo for Next.js applications
Apache License 2.0
152 stars 21 forks source link

feat: add a callback to know when the script does not load #125

Closed totakoko closed 4 months ago

totakoko commented 5 months ago

fix #124

Add the onScriptLoadingError callback which is called when the Matomo script can't be loaded (e.g. when an ad blocker is used).

totakoko commented 5 months ago

@revolunet I tried writing tests but it was cumbersome and I lack jsdom knowledge so I gave up... :persevere: Is that a problem?

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

revolunet commented 4 months ago

LGTM, thank you !

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 1.9.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: