search

SocialGouv / matomo-next

Matomo for Next.js applications
Apache License 2.0
155 stars 22 forks source link

feat: add possibility to surcharge next router listener #88

Closed maxgfr closed 1 year ago

maxgfr commented 1 year ago

This branch allows users to surcharge the method from Next.js router onChangeStart and onChangeComplete that is used in the library

maxgfr commented 1 year ago

@m-maillot @Viczei @carolineBda Vous en pensez quoi ?

De mon côté, je pensais propager d'autres valeurs supplémentaires comme previousPath ou isExcludedUrl.

D'ailleurs ça peut poser soucis ici car on ne va pas le setter

codecov-commenter commented 1 year ago

Codecov Report

Base: 85.00% // Head: 86.15% // Increases project coverage by +1.15% :tada:

Coverage data is based on head (ecfc5fd) compared to base (9d3b799). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #88 +/- ## ========================================== + Coverage 85.00% 86.15% +1.15% ========================================== Files 1 1 Lines 60 65 +5 Branches 16 20 +4 ========================================== + Hits 51 56 +5 Misses 1 1 Partials 8 8 ``` | [Impacted Files](https://codecov.io/gh/SocialGouv/matomo-next/pull/88?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv) | Coverage Δ | | |---|---|---| | [src/index.ts](https://codecov.io/gh/SocialGouv/matomo-next/pull/88?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv#diff-c3JjL2luZGV4LnRz) | `86.15% <100.00%> (+1.15%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SocialGouv)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.5.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: