SocialGouv / mda

Aider les personnes concernées par l'autisme à trouver leurs réponses et à mener à bien leurs démarches.
Apache License 2.0
5 stars 0 forks source link

feat: dsfr consent banner #268

Closed paulsouche closed 1 year ago

paulsouche commented 1 year ago

Closes #87

Objectif(s)

Cette PR remplace tarte au citron par une implem DSFR

gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [6157067](https://dashboard.gitguardian.com/incidents/6157067?occurrence=90462407) | Generic High Entropy Secret | c80a8a6bc953c5026bac642cc621dee31abd0d61 | .kontinuous/env/prod/values.yaml | [View secret](https://github.com/SocialGouv/mda/commit/c80a8a6bc953c5026bac642cc621dee31abd0d61#diff-c33adffb51b907fbca7bf14ad2ee3ad18505b61240e55a43a9429674f4f0cf7cL3) | | [6157068](https://dashboard.gitguardian.com/incidents/6157068?occurrence=90462408) | Generic High Entropy Secret | c80a8a6bc953c5026bac642cc621dee31abd0d61 | .kontinuous/env/prod/values.yaml | [View secret](https://github.com/SocialGouv/mda/commit/c80a8a6bc953c5026bac642cc621dee31abd0d61#diff-c33adffb51b907fbca7bf14ad2ee3ad18505b61240e55a43a9429674f4f0cf7cL30) | | [6157067](https://dashboard.gitguardian.com/incidents/6157067?occurrence=90462406) | Generic High Entropy Secret | c80a8a6bc953c5026bac642cc621dee31abd0d61 | .kontinuous/env/prod/values.yaml | [View secret](https://github.com/SocialGouv/mda/commit/c80a8a6bc953c5026bac642cc621dee31abd0d61#diff-c33adffb51b907fbca7bf14ad2ee3ad18505b61240e55a43a9429674f4f0cf7cR99) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

github-actions[bot] commented 1 year ago

🎉 Deployment for commit 5cf368f6d36d9f30c759a0a5e7c838b48d45419b :

Ingresses - 🚀 [https://maildev-mda-feat-orejime-2qvqovhr.dev.fabrique.social.gouv.fr/](https://maildev-mda-feat-orejime-2qvqovhr.dev.fabrique.social.gouv.fr/) - 🚀 [https://mda-feat-orejime-2qvqovhr.dev.fabrique.social.gouv.fr/](https://mda-feat-orejime-2qvqovhr.dev.fabrique.social.gouv.fr/) - 🚀 [https://strapi-mda-feat-orejime-2qvqovhr.dev.fabrique.social.gouv.fr/](https://strapi-mda-feat-orejime-2qvqovhr.dev.fabrique.social.gouv.fr/)
Docker images - 📦 docker pull getmeili/meilisearch:v1.1.0 - 📦 docker pull harbor.fabrique.social.gouv.fr/maison-de-l-autisme/mda/strapi:sha-5cf368f6d36d9f30c759a0a5e7c838b48d45419b - 📦 docker pull harbor.fabrique.social.gouv.fr/maison-de-l-autisme/mda/web:sha-5cf368f6d36d9f30c759a0a5e7c838b48d45419b - 📦 docker pull maildev/maildev:latest
Debug - [📕 Loki logs for namespace mda-feat-orejime-2qvqovhr](https://grafana.fabrique.social.gouv.fr/explore?orgId=1&left=%5B%22now-6h%22,%22now%22,%22Loki%22,%7B%22expr%22:%22%7Bnamespace%3D%5C%22mda-feat-orejime-2qvqovhr%5C%22%7D%22%7D%5D) - [📈 Pods monitoring for namespace mda-feat-orejime-2qvqovhr](https://grafana.fabrique.social.gouv.fr/d/85a562078cdf77779eaa1add43ccec1e/kubernetes-compute-resources-namespace-pods?orgId=1&refresh=10s&var-datasource=default&var-cluster=dev2&var-namespace=mda-feat-orejime-2qvqovhr) - [📈 Workloads monitoring for namespace mda-feat-orejime-2qvqovhr](https://grafana.fabrique.social.gouv.fr/d/a87fb0d919ec0ea5f6543124e16c42a5/kubernetes-compute-resources-namespace-workloads?orgId=1&refresh=10s&var-datasource=default&var-cluster=dev2&var-namespace=mda-feat-orejime-2qvqovhr&var-type=deployment) - [👮‍♂️ Namespace rancher mda-feat-orejime-2qvqovhr](https://rancher.fabrique.social.gouv.fr/dashboard/c/c-gjtkk/explorer/namespace/mda-feat-orejime-2qvqovhr) - [👮‍♂️ Deployment maildev](https://rancher.fabrique.social.gouv.fr/dashboard/c/c-gjtkk/explorer/apps.deployment/mda-feat-orejime-2qvqovhr/maildev) - [👮‍♂️ Deployment meilisearch](https://rancher.fabrique.social.gouv.fr/dashboard/c/c-gjtkk/explorer/apps.deployment/mda-feat-orejime-2qvqovhr/meilisearch) - [👮‍♂️ Deployment strapi](https://rancher.fabrique.social.gouv.fr/dashboard/c/c-gjtkk/explorer/apps.deployment/mda-feat-orejime-2qvqovhr/strapi) - [👮‍♂️ Deployment web](https://rancher.fabrique.social.gouv.fr/dashboard/c/c-gjtkk/explorer/apps.deployment/mda-feat-orejime-2qvqovhr/web)
sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

SocialGroovyBot commented 1 year ago

:tada: This PR is included in version 1.15.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: