SocialGouv / mda

Aider les personnes concernées par l'autisme à trouver leurs réponses et à mener à bien leurs démarches.
Apache License 2.0
5 stars 0 forks source link

fix(k9s): disable prod web replicas #364

Closed revolunet closed 1 year ago

revolunet commented 1 year ago

Looks like having multiple replicas cause some weird issue with caching

https://sentry.fabrique.social.gouv.fr/organizations/incubateur/issues/101784/events/?environment=production&project=83&project=89&referrer=issue-stream&stream_index=3

gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [6157067](https://dashboard.gitguardian.com/incidents/6157067?occurrence=98270819) | Generic High Entropy Secret | a087ed21f1bbf277738d350224aa53671826da60 | .kontinuous/env/prod/values.yaml | [View secret](https://github.com/SocialGouv/mda/commit/a087ed21f1bbf277738d350224aa53671826da60#diff-c33adffb51b907fbca7bf14ad2ee3ad18505b61240e55a43a9429674f4f0cf7cL99) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

SocialGroovyBot commented 1 year ago

:tada: This PR is included in version 1.24.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: