search

SocialiteProviders / Manager

Easily add new or override built-in Laravel Socialite providers
https://socialiteproviders.com/contribute/
MIT License
393 stars 84 forks source link

Laravel 6.0 support #146

Closed dpsarrou closed 5 years ago

dpsarrou commented 5 years ago

Issue / Motivation:

I would like to update my project to laravel 6 and this package's dependency to illuminate/support up to ~5.8.0 is preventing me.

Expected behavior:

composer update should allow me to update the project

Actual behavior:

Composer errors complaining about unsupported dependency.

Steps to reproduce the behavior:

Given composer.json defines a dependency of "laravel/framework": "^6.0", running composer prohibits laravel/framework shows:

socialiteproviders/manager          v3.3.7        requires  illuminate/support (~5.4|~5.7.0|~5.8.0)

Proposed solution:

Add support for "illuminate/support":"~5.4|~5.7.0|~5.8.0|^6.0" similar to how laravel/socialite is supporting it.

m1guelpf commented 5 years ago

Just tagged a new release

Francismori7 commented 5 years ago

Just tagged a new release

The new release does not actually work with 6.0 though. See #147

m1guelpf commented 5 years ago

@Francismori7 I also encountered this yesterday after tagging the release, but couldn't find the issue. My workaround was to add this to the boot method of my EventServiceProvider:

event(app(SocialiteWasCalled::class));

Glad to accept any PR that fixes this

m1guelpf commented 5 years ago

@Francismori7 tagged a new release